chore(QTDI-2456): fix cve for qs with overrides #1161
+4,900
−7,095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undx
requested review from
Copilot and
yyin-talend
and removed request for
Copilot
There was a problem hiding this comment.
Pull request overview
This PR addresses a security vulnerability (CVE) in the qs package by adding an override to enforce version >=6.14.1 across frontend package configurations. The changes also reorganize dependencies alphabetically for better maintainability.
Changes:
- Added
qspackage override to enforce minimum version>=6.14.1for security - Reorganized dependencies alphabetically in package.json files
- Updated
path-to-regexpfrom version0.1.10to0.1.12in devDependencies
Reviewed changes
Copilot reviewed 4 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| component-tools-webapp/src/main/frontend/package.json | Added qs override and reorganized dependencies alphabetically |
| component-tools-webapp/src/main/frontend/package-template.json | Added qs override and reorganized dependencies alphabetically |
| component-starter-server/src/main/frontend/package.json | Added qs override to existing overrides section and reorganized dependencies |
| component-starter-server/src/main/frontend/package-template.json | Added qs override to existing overrides section and reorganized dependencies |
Files not reviewed (1)
- component-tools-webapp/src/main/frontend/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
0 New Issues
0 Fixed Issues
0 Accepted Issues
No data about coverage (0.00% Estimated after merge)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://qlik-dev.atlassian.net/browse/QTDI-2456
See comment in jira issue.