fix(logic-script): add proper connectionType for list variable types #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The mapTypeToSchema function was missing connectionType metadata for list-text, list-number, list-boolean, and list-json types. This caused the Script/Logic component to fail when connecting to upstream components that output List<JSON> (e.g., httpx results). Changes: - Add connectionType for list/list-text types - Add connectionType for list-number type - Add connectionType for list-boolean type - Add connectionType for list-json type with allowAny flag This enables proper port connections in the workflow builder UI. Signed-off-by: fmzchao <root@7jdg.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
connectionTypemetadata for list variable types in Script/Logic componentThe
mapTypeToSchemafunction was missingconnectionTypemetadata for list types (list-text,list-number,list-boolean,list-json). This caused the component to fail when connecting to upstream components that outputList<JSON>types (e.g., httpx'sresultsoutput).Changes:
connectionTypeforlist/list-text→List<Text>connectionTypeforlist-number→List<Number>connectionTypeforlist-boolean→List<Boolean>connectionTypeforlist-json→List<JSON>withallowAny: trueTesting
bun run test- All tests passbun run lintbun run typecheckresultsoutput usinglist-jsoninput typeDocumentation