fix(component-sdk): prevent Docker -t flag removal from filtering command arguments #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mand arguments The PTY fallback code used filter(arg => arg !== '-t') which removed ALL occurrences of '-t' from the docker args array, including command arguments like 'findomain -t example.com'. This caused tools that use -t as a parameter to fail with 'argument not expected' errors. Fixed by only removing the first occurrence of -t within the first 10 args (where Docker flags are located), preserving any -t in the actual command. Signed-off-by: fmzchao <root@7jdg.com>
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
-tflag removal from filtering command argumentsThe PTY fallback code in
runner.tsusedfilter(arg => arg !== '-t')which removed ALL occurrences of-tfrom the docker args array, including command arguments likefindomain -t example.com.This caused tools that use
-tas a parameter to fail with errors like:Solution: Only remove the first occurrence of
-twithin the first 10 args (where Docker flags are located), preserving any-tin the actual command arguments.Testing
bun run testbun run lintbun run typecheck-tflag for target specification. Before the fix, the-twas stripped and the command failed. After the fix, the command executes correctly.Documentation