Skip to content

Conversation

@BryanFauble
Copy link
Member

Problem:

  • Functionality was added to the python client which is not supported in the Rest API around filtering logic
  • When using the wrap generator function it would not return results until all results were retrieved

Solution:

  • Remove the filtering logic in the Submission APIs
  • Update the generator to return results

Testing:

  • I ran through the tutorial and will review the test runs

…emoving param passing to several submission related APIs which do not support it
@BryanFauble BryanFauble requested a review from a team as a code owner January 8, 2026 18:29
@BryanFauble BryanFauble requested a review from jaymedina January 8, 2026 18:30
Copy link
Contributor

@jaymedina jaymedina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the patch!

lg, but it's unclear to me what caused the infinite loop for those test cases as I wasn't able to reproduce the issue. it seems that with some of the parameters of the API services not being exposed, calls to these APIs would default to limit=10, offset=0, etc, so the generator wrapper would have grabbed a finite amount of submissions regardless.

@BryanFauble BryanFauble merged commit ccc043c into develop Jan 9, 2026
69 of 94 checks passed
@BryanFauble BryanFauble deleted the synpy-1590-submission-changes branch January 9, 2026 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants