Cargo.toml: add workspace-level clippy config #1411
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a set of workspace-level lints including common ones we've used in
the past and others collected via running `clippy::pedantic` on several
of our crates and looking for interesting ones.
Workspace-level lints require explict opt-in from each crate's
Cargo.toml, so there's nothing forcing any crate to use them:
[lints]
workspace = true
That said, I have opted every crate in the workspace into these lints
and gotten them all to pass except for `wycheproof2blb` which is an
internal utility tool and I didn't feel like it was worth the hassle.
Even then, the lints are all set to `"warn"`, so they can be easily
overridden by `#[allow(...)]` attributes, including `#![allow(...)]`
to shut them off at the granularity of an entire crate.
I managed to fix most of the issues that `cargo clippy --fix` didn't fix
automatically including some missing documentation and documentation
formatting issues.
The main thing I didn't fix was adding missing `SAFETY` comments,
which is a problem with a few of the crates in this repo. I disabled a
lint at the crate level and added a TODO where we're missing them and it
wasn't easily corrected.
Member
Author
|
A couple of changes from #1399
However the changes for above are still in there and I need to go back and clean them up. Beyond that, we need a solution for Anything else? |
newpavlov
reviewed
Jan 20, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Duplicating comments from the previous PR.
Member
Author
|
Alright, I think that's everything except what to do about |
newpavlov
approved these changes
Jan 21, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Approving on condition of minimal-versions being fixed.
tarcieri
added a commit
to RustCrypto/actions
that referenced
this pull request
Jan 21, 2026
Generates a stub Cargo.toml at the workspace level which configures a workspace with one member whose path is the current working directory. I think this might resolve the problem I was having with using workspace-level configs in conjunction with `minimal-versions` on RustCrypto/utils#1411 Not sure how to test it
Member
Author
|
Okay, getting closer... Might actually end up needing something multi-line after all, heh |
Member
Author
|
Looks like RustCrypto/actions#53 did the trick and |
This was referenced Jan 21, 2026
tarcieri
added a commit
that referenced
this pull request
Jan 21, 2026
These sorts of imperative-style loops are often one of the easiest-to-read solutions to simple problems. I thought I added this to #1411 but I guess it got lost along the way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(NOTE: take 2, after I accidentally closed #1399)
Adds a set of workspace-level lints including common ones we've used in the past and others collected via running
clippy::pedanticon several of our crates and looking for interesting ones.Workspace-level lints require explict opt-in from each crate's Cargo.toml, so there's nothing forcing any crate to use them:
That said, I have opted every crate in the workspace into these lints and gotten them all to pass except for
wycheproof2blbwhich is an internal utility tool and I didn't feel like it was worth the hassle.Even then, the lints are all set to
"warn", so they can be easily overridden by#[allow(...)]attributes, including#![allow(...)]to shut them off at the granularity of an entire crate.I managed to fix most of the issues that
cargo clippy --fixdidn't fix automatically including some missing documentation and documentation formatting issues.The main thing I didn't fix was adding missing
SAFETYcomments, which is a problem with a few of the crates in this repo. I disabled a lint at the crate level and added a TODO where we're missing them and it wasn't easily corrected.See also: RustCrypto/meta#24