Skip to content

Conversation

@baloo
Copy link
Member

@baloo baloo commented Jan 19, 2026

This fixes changes made in #2195

This is due to the refactor made in rand_core in rust-random/rand_core#45 which dropped the "trait dependency" between CryptoRng and RngCore

Copy link
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I see, it's CryptoRng: TryRngCore<Error = Infallible>. Do I need to ask for CryptoRngCore back? 😅

@tarcieri tarcieri merged commit 2100251 into RustCrypto:master Jan 19, 2026
14 checks passed
@baloo baloo deleted the baloo/push-xlzzsxkxmvrx branch January 19, 2026 21:46
@newpavlov
Copy link
Member

newpavlov commented Jan 19, 2026

Hm... I expected that CryptoRng should work just fine since it implements TryCryptoRng<Error=!> and thus TryRngCore<Error=!> and it in turn should mean that it implements RngCore, but I guess the compiler is not able to see through the double indirection and it's worth to change the definition to CryptoRng: TryRngCore<Error=!> + RngCore.

@tarcieri
Copy link
Member

Yeah that is weird, I don't get why the blanket impl doesn't suffice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants