set(): only reallocate the table if resizing would fail otherwise
#7606
+33
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7606 +/- ##
==========================================
+ Coverage 99.01% 99.02% +0.01%
==========================================
Files 87 87
Lines 16896 16903 +7
==========================================
+ Hits 16730 16739 +9
+ Misses 166 164 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
No obvious timing issues in HEAD=fix-7604 Generated via commit 599f1cb Download link for the artifact containing the test results: ↓ atime-results.zip
|
Member
|
Did we want to include this in 1.18.2 as well? |
Co-authored-by: Michael Chirico <chiricom@google.com>
Co-Authored-By: Michael Chirico <michaelchirico4@gmail.com>
ben-schwen
reviewed
Jan 20, 2026
R/data.table.R
Outdated
| # when removing a column, value can be NULL or list with NULLs inside | ||
| removing = is.null(value) || (is.list(value) && length(value) == length(j) && any(vapply_1b(value, is.null))) | ||
| # columns can be created by name | ||
| adding = is.character(j) && !all(j %chin% names(x)) |
Member
There was a problem hiding this comment.
should we caching the result of j %chin% names(x) here?
Co-Authored-By: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com
Member
Author
|
Shouldn't need a NEWS item as a follow-up to #7538. |
aitap
added a commit
that referenced
this pull request
Jan 20, 2026
…7606) * Regression tests * set(): only reallocate if resizing would fail * Update R/data.table.R Co-authored-by: Michael Chirico <chiricom@google.com> * Rename test variables Co-Authored-By: Michael Chirico <michaelchirico4@gmail.com> * Cache j %chin% names(x) Co-Authored-By: Benjamin Schwendinger <52290390+ben-schwen@users.noreply.github.com --------- Co-authored-by: Michael Chirico <chiricom@google.com> Co-authored-by: Michael Chirico <michaelchirico4@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular, do not reallocate when changing existing columns without resizing the table. Reallocating and reassigning the table in the caller misses the cases when the table is shared outside the caller's frame (e.g. the caller's caller).
Fixes: #7604