Skip to content

Fix tests failing due to underfined ordering #659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zetter-rpf wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix tests failing due to underfined ordering #659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions spec/concepts/school_student/list_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,11 @@
described_class.call(school:, token:)

# TODO: Replace with WebMock assertion once the profile API has been built.
expect(ProfileApiClient).to have_received(:list_school_students).with(token:, school_id: school.id, student_ids: students.map(&:id))
expect(ProfileApiClient).to have_received(:list_school_students).with(
token:,
school_id: school.id,
student_ids: match_array(students.map(&:id))
)
end

it 'returns a school students JSON array' do
Expand Down Expand Up @@ -61,7 +65,11 @@
described_class.call(school:, token:, student_ids:)

# TODO: Replace with WebMock assertion once the profile API has been built.
expect(ProfileApiClient).to have_received(:list_school_students).with(token:, school_id: school.id, student_ids:)
expect(ProfileApiClient).to have_received(:list_school_students).with(
token:,
school_id: school.id,
student_ids: match_array(student_ids)
)
end

it 'returns a filtered school students JSON array' do
Expand Down