Fix header logo sizing and baseline gap #748
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SVG logo files, which are used for branded sites with using
<img>tag, were missing width and height attributes, causing them to have no intrinsic dimensions. This meant the browser couldn't determine their natural size, requiring explicit CSS height to display them at all.Our solution was to add use
height: 100px;, but this created gaps in case SVG had smaller height (we also havemax-width: 300px;applied, so "landscape" logos had the gap).Additionally, the logo container was slightly taller than the image due to the default inline image alignment sitting on the text baseline, which reserves space for letters like g, y, p.
This PR fixes that problem by adding:
In case a custom dimensions need to be applied for specific brand, we can use it's Custom CSS field on the server side.