Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

SVG logo files, which are used for branded sites with using <img> tag, were missing width and height attributes, causing them to have no intrinsic dimensions. This meant the browser couldn't determine their natural size, requiring explicit CSS height to display them at all.

Our solution was to add use height: 100px;, but this created gaps in case SVG had smaller height (we also have max-width: 300px; applied, so "landscape" logos had the gap).

Additionally, the logo container was slightly taller than the image due to the default inline image alignment sitting on the text baseline, which reserves space for letters like g, y, p.

This PR fixes that problem by adding:

  • width and height attributes to logo SVG files, giving them proper intrinsic dimensions (I have done this manually on the server)
  • CSS to use max-width and max-height as constraints while allowing the images to display at their natural size
  • vertical-align: bottom to eliminate the baseline gap

In case a custom dimensions need to be applied for specific brand, we can use it's Custom CSS field on the server side.

@ilicfilip ilicfilip requested a review from aristath January 23, 2026 09:54
@github-actions
Copy link
Contributor

Test on Playground
Test this pull request on the Playground
or download the zip

@github-actions
Copy link
Contributor

✅ Code Coverage Report

Metric Value
Total Coverage 31.61% 📉
Base Coverage 31.61%
Difference 📈 0.00%

⚠️ Coverage below recommended 40% threshold

🎉 Great job maintaining/improving code coverage!

ℹ️ About this report
  • All tests run in a single job with Xdebug coverage
  • Security tests excluded from coverage to prevent output issues
  • Coverage calculated from line coverage percentages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants