Fix Corrupted Gems import and update gem tooltip #1743
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blitz54
force-pushed
the
gem-level-tooltip
branch
from
d2d978f to
e425327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1739
Fixes #1738
Description of the problem being solved:
Importing skills now adds a corrupted tag to the gem instance. I added a dropdown to the skills page, to select if the item is corrupted, and if it has -1 or +1 to the skill. Importing matches with the dropdown, before we were always added a gem level even if it was a lost gem level.
Tooltip for gem shows where the levels come from, same as in game.
After screenshot: