Renaming pyfunc to kernels #2490
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvansebille
commented
Jan 21, 2026
| FieldInterpolationError, | ||
| FieldOutOfBoundError, | ||
| FieldSet, | ||
| Kernel, |
Member
Author
There was a problem hiding this comment.
We could now even think about making Kernel a private class, as users won't need to interact with it anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements #2275 by renaming the
pyfuncargument tokernels.It also simplifies the pset.execute() by assuming that the input is a list of functions, rather than Kernel objects. This means that
pset.Kernelis not needed anymore, and we can get rid of a few helper functions, decluttering the code