🩹 [Patch]: Replace secrets inheritance with explicit secret passing #137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix unconditional secrets inheritance warning in Process-PSModule workflow
Fix unconditional secrets inheritance in Process-PSModule workflow
Jan 23, 2026
MariusStorhaug
changed the title
MariusStorhaug
added
the
Patch
MariusStorhaug
requested changes
Jan 23, 2026
Co-authored-by: MariusStorhaug <17722253+MariusStorhaug@users.noreply.github.com>
MariusStorhaug
changed the title
There was a problem hiding this comment.
Pull request overview
This PR improves workflow security by replacing unconditional secrets: inherit with explicit secret passing in the Process-PSModule workflow, addressing a zizmor security linting warning flagged in issue #136.
Changes:
- Updated
.github/workflows/Process-PSModule.ymlto explicitly pass only the requiredAPIKeysecret instead of inheriting all repository secrets
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MariusStorhaug
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Contributor
|
Module GoogleFonts - 1.0.103 published to the PowerShell Gallery. |
Contributor
|
GitHub release for GoogleFonts v1.0.103 has been created. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves workflow security by replacing unconditional
secrets: inheritwith explicit secret passing in the Process-PSModule workflow. This follows the principle of least privilege by only passing the requiredAPIKeysecret instead of exposing all repository secrets to the reusable workflow.Changes
.github/workflows/Process-PSModule.yml: Changed fromsecrets: inheritto explicitly passing only the requiredAPIKeysecret usingAPIKey: ${{ secrets.APIKey }}.Benefits