fix: Improve code quality in ivy_guc.c #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix typo in comment (line 59): "blow" → "below" - Remove trailing whitespace in comment (line 187) - Fix typo in gettext (line 423): "charater" → "character" - Fix typo in error message (line 480): remove double period - Add errcode() to ereport() calls (lines 582, 584-585, 604-605): * ERRCODE_STRING_DATA_RIGHT_TRUNCATION for length check * ERRCODE_INVALID_PARAMETER_VALUE for NLS errors - Optimize nls_case_conversion() by caching strlen() result Change O(N²) to O(N) performance complexity - Replace magic numbers with character constants: * 97, 122 → 'a', 'z' * 65, 90 → 'A', 'Z' Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves code quality in
ivy_guc.cwith the following changes:errcode()toereport()calls for better PostgreSQL error handling:ERRCODE_STRING_DATA_RIGHT_TRUNCATIONfor length validation errorsERRCODE_INVALID_PARAMETER_VALUEfor NLS parameter errorsstrlen()result innls_case_conversion()function, changing complexity from O(N²) to O(N)Test Plan