Skip to content

Conversation

@OreoYang
Copy link
Owner

Summary

This PR fixes several style issues and bugs in src/backend/utils/misc/ivy_guc.c:

  • Fixed typo: Changed "shown as blow" to "shown below" in comment (line 59)
  • Fixed duplicate period: Removed extra period in error hint message (line 479)
  • Fixed null terminator bug: Corrected placement of null terminator in nls_case_conversion function (lines 537, 545)
    • The null terminator was being set inside the loop, which would overwrite the last character
    • Now correctly placed after the loop completion
  • Code style: Removed extra blank lines for consistent formatting (lines 75, 77)
  • License header: Added missing period in Apache License header (line 6)

Test Plan

  • Build completed successfully
  • All Oracle compatibility tests passed (make oracle-check)
  • No regression test failures

Files Changed

  • src/backend/utils/misc/ivy_guc.c: 1 file changed, 14 insertions(+), 17 deletions(-)

🤖 Generated with Claude Code

- Fix typo: "shown as blow" -> "shown below"
- Fix duplicate period in error hint message
- Fix null terminator placement in nls_case_conversion function
- Remove extra blank lines for consistent code style
- Add missing period in Apache License header

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants