-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix: phpstan level 5 errors #84 #100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Morgy93
wants to merge
15
commits into
main
Choose a base branch
from
fix-phpstan-5
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request primarily includes refactoring and minor behavior adjustments across several files to improve code clarity, error handling, and dependency management. The most important changes involve relaxing static analysis requirements, refining command return values, and cleaning up unused dependencies.
Static Analysis and CI Adjustments:
phpstan.neon, making static analysis less strict.continue-on-error: truefrom the PHPStan GitHub Actions workflow, so the workflow will now fail on PHPStan errors.Command and Return Value Handling:
TokensCommand.phpandInspectorCommand.phpto returnnullinstead ofCli::RETURN_FAILUREin some cases, aligning return values with expected behaviors and possibly improving error handling. [1] [2] [3]Dependency and Constructor Cleanup:
ThemePathandCompatibilityChecker, simplifying these classes and reducing coupling. [1] [2]Logic and Behavior Refinements:
StaticContentCleanerto return a boolean based only on files being cleaned, not on the existence of static files, clarifying its intent.InspectorHintsto skip block hint injection when not enabled, preventing unnecessary processing.Miscellaneous Cleanup:
PACKAGE_NAMEconstant fromVersionCommand.php.