-
Notifications
You must be signed in to change notification settings - Fork 0
Update Core #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Core #4
Conversation
Removed prerelease input option and set it to true.
Add guideline requiring a short (<=72 chars) title, a blank line, and optional body to AGENTS.md files for agents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e9e0d64100
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| # The VCS trait and VCS-related error type. | ||
| vcs = ["dep:thiserror"] | ||
| vcs = ["dep:thiserror", "backend-registry"] | ||
|
|
||
| # Static + dynamic backend registry (linkme + logging). | ||
| backend-registry = ["vcs", "dep:linkme", "dep:log"] | ||
| # Backend discovery via the `BACKENDS` registry (link-time registration). | ||
| backend-registry = ["dep:linkme"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make backend-registry imply vcs again
backend_descriptor.rs imports crate::{Result, Vcs}, which are only defined under feature = "vcs" (see src/lib.rs). After this change, backend-registry no longer enables vcs, so cargo build --no-default-features --features backend-registry will now fail with unresolved imports. This is a regression from the previous feature graph. Consider restoring vcs as a dependency of backend-registry or gating backend_descriptor behind both features.
Useful? React with 👍 / 👎.
No description provided.