Skip to content

Conversation

@chassq
Copy link

@chassq chassq commented Jan 19, 2026

Clarify security concerns regarding SQL logins for elastic queries.

Clarify security concerns regarding SQL logins for elastic queries.
@prmerger-automator
Copy link
Contributor

@chassq : Thanks for your contribution! The author(s) and reviewer(s) have been notified to review your proposed change.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a security note to the Azure SQL Database elastic query documentation, clarifying that elastic queries only support SQL logins and highlighting the security implications of this limitation.

Changes:

  • Added a new limitation bullet point regarding SQL login support and associated security concerns


- Private links are currently not supported with elastic query for those databases that are targets of external data sources.

- Elastic queries only support SQL logins. This presents a security problem as SQL logins are not recommneded to be used as they require passwords to be stored and securly maintained in other resources. Until elastic queries support managed identity they are not recommended from a security perspective.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence structure needs improvement. According to the Microsoft Writing Style Guide, sentences should be concise and clear. Consider breaking this long sentence into multiple sentences or restructuring it for better readability. Additionally, avoid phrases like "security problem" - use more specific, technical language such as "security concern" or "security limitation".

Copilot uses AI. Check for mistakes.
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is neither a limitation nor concern. This is a problem. Plain and simple. It opens up the uninitiated to a security problem if they do not understand the implication of using SQL Logins. Elastic queries should only support Managed identity and not support SQL logins. However since that is not currently the case the problem should be clearly called out.


- Private links are currently not supported with elastic query for those databases that are targets of external data sources.

- Elastic queries only support SQL logins. This presents a security problem as SQL logins are not recommneded to be used as they require passwords to be stored and securly maintained in other resources. Until elastic queries support managed identity they are not recommended from a security perspective.
Copy link

Copilot AI Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two spelling errors detected: "recommneded" should be "recommended" and "securly" should be "securely".

Suggested change
- Elastic queries only support SQL logins. This presents a security problem as SQL logins are not recommneded to be used as they require passwords to be stored and securly maintained in other resources. Until elastic queries support managed identity they are not recommended from a security perspective.
- Elastic queries only support SQL logins. This presents a security problem as SQL logins are not recommended to be used as they require passwords to be stored and securely maintained in other resources. Until elastic queries support managed identity they are not recommended from a security perspective.

Copilot uses AI. Check for mistakes.
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit ebae420:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/elastic-query-overview.md ✅Succeeded

For more details, please refer to the build report.

spelling correction

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@learn-build-service-prod
Copy link
Contributor

Learn Build status updates of commit d9f1f34:

✅ Validation status: passed

File Status Preview URL Details
azure-sql/database/elastic-query-overview.md ✅Succeeded

For more details, please refer to the build report.

@ttorble
Copy link
Contributor

ttorble commented Jan 19, 2026

@WilliamDAssafMSFT

Can you review the proposed changes?

IMPORTANT: When the changes are ready for publication, adding a #sign-off comment is the best way to signal that the PR is ready for the review team to merge.

#label:"aq-pr-triaged"
@MicrosoftDocs/public-repo-pr-review-team

@prmerger-automator prmerger-automator bot added the aq-pr-triaged tracking label for the PR review team label Jan 19, 2026
@rwestMSFT
Copy link
Contributor

This PR requires a style pass to meet our documentation guidelines, which includes removing some of the wording. It may take several days to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants