refactor: pull in changes from mv3-ltl branch #193
+45
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arkon
force-pushed
the
merge-mv3-ltl-into-main
branch
from
af7df30 to
1fe5c89
Compare
r2dev2
reviewed
Jan 26, 2026
| return { | ||
| // eslint-disable-next-line @typescript-eslint/ban-ts-comment | ||
| // @ts-expect-error | ||
| ...actualPort, |
Member
There was a problem hiding this comment.
I guess this is there in the original commit that introduced this (7382aa5), but worth noting that ...actualPort will just spread ...null, so it should probably be removed at some point.
r2dev2
approved these changes
Jan 26, 2026
Member
r2dev2
left a comment
r2dev2
left a comment
There was a problem hiding this comment.
LGTM! Now, there is no divergence between main and mv3-ltl.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention is to reduce the number of different branches where possible.
AFAIK, these diffs don't actually matter to really differentiate between vanilla HyperChat and LiveTL behaviour, especially given the
mainMV3 logic already has other LiveTL-gated logic.