fix(merge): prevent silent data loss in CSV merge pipeline #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug fixes: - BUG 1: Use consistent normalization for mapping_dict keys and df_new lookups - BUG 2: Handle missing 'variations' key with .get() defaults - BUG 3: Check column existence before accessing cfp_ext_x/y merge columns - BUG 4: Deduplicate by [conference, year] to preserve multi-year entries Added 22 regression tests in tests/test_merge_no_data_loss.py covering: - Normalization consistency and idempotency - No silent data loss during merge - Variations key handling - cfp_ext column handling - Multi-year deduplication
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes:
Added 22 regression tests in tests/test_merge_no_data_loss.py covering: