Skip to content

Conversation

@hjmjohnson
Copy link
Member

Review the Insight Software guide and run the chktex linting tool
to identify places where the software guide can be made more robust.

@github-actions github-actions bot added area:Introduction Issues affecting the Introduction part area:DevelopmentGuidelines Issues affecting the Development Guidelines part area:Examples Issues affecting the ITK Examples scraper area:DesignAndFunctionality Issues affecting the Design And Functionality part area:Cover Issues affecting the Cover area:Architecture Issues affecting the Architecture part area:Appendices Issues affecting the Appendices part language:LaTeX Changes to LaTeX code type:Artwork Changes to artwork files type:BookStyle Changes to book style files type:Infrastructure labels Jan 15, 2026
@hjmjohnson hjmjohnson force-pushed the fix-latex2e-compliance branch from 5d45482 to e37c614 Compare January 15, 2026 22:39
The 3 times running of latex has been done with cmake logic since 2015.
The hyperref option should be correctly inferred in all
modern versions of latex.  This avoids problems when building
the document with other tools (like pandoc, pdflatex, or latexmk).
@hjmjohnson hjmjohnson force-pushed the fix-latex2e-compliance branch from e37c614 to 17b932e Compare January 16, 2026 00:21
thewtex
thewtex previously approved these changes Jan 16, 2026
@thewtex thewtex dismissed their stale review January 16, 2026 03:13

CI failing

@hjmjohnson hjmjohnson force-pushed the fix-latex2e-compliance branch from 17b932e to b0ea96d Compare January 16, 2026 13:56
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good. Cursory review identified some questions.

In modern LaTeX, you should not use the old two-letter command \bf.
Instead, you should use the recommended \textbf{...} command or the
\bfseries declaration for producing bold text.
Search for and replace obsolete font commands in all .tex
- Replace `{\bf ...}` with `\textbf{...}`
- Replace `{\it ...}` with `\textit{...}`
- Replace `{\tt ...}` with `\texttt{...}`
- Replace `{\rm ...}` with `\textrm{...}`
- Replace `{\sc ...}` with `\textsc{...}`
- Replace `{\sf ...}` with `\textsf{...}`
- Replace `{\sl ...}` with `\textsl{...}`
- Replace `{\cal ...}` with `\mathcal{...}`
- Replace `{\em ...}` with `\emph{...}`

Search for and replace other obsolete commands:
- Replace `\over` with `\frac{...}{...}` or `\overline{...}`:
Prevent LaTeX line breaks that may cause a \label or \index to be referenced in the wrong place for page references.

Delete this space to maintain correct pagereferences.

Found with `chktex` latex linting tool
Ensures proper layout and prevent misaligned page references
cite, ref, pageref, Figure, Table should have the reference
information adjacent to the preceeding text for clarity.
A linter test suggestion by chktex
Replace the literal double-quote character in LaTeX.

It is for the rare cases where you actually want the ASCII " glyph, not typographic quotes.
chktex warns when " character is used without explicit request for the
type of quotes needed.
…` tables

Improve the visual representation of tables following recommendations provided
by chktex linting and online suggestions.
User Regex: 1:Capitalize before references.
For identifying and addressing common formatting issues
This ensures compatibility by requiring ImageMagick version 6 or greater
and the `convert` component in relevant CMake files. Updates improve
dependency clarity, preventing potential issues with older versions or
missing components.

ImageMagick version 7 was released as a production version in May 2016.
ImageMagick version 7 deprecates the 'convert' tool which will be removed
in future version.

Support both version 6 and 7 with cmake syntax introduced in cmake
version 3.9.
@hjmjohnson hjmjohnson force-pushed the fix-latex2e-compliance branch from b0ea96d to 6feafa5 Compare January 16, 2026 16:51
@hjmjohnson hjmjohnson requested review from dzenanz and thewtex January 16, 2026 17:37
@hjmjohnson
Copy link
Member Author

@dzenanz I think I addressed all the issues you mentioned.

@hjmjohnson
Copy link
Member Author

@thewtex I had a silly syntax error that needed fixing. This is now done.

Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hjmjohnson thanks!

@thewtex thewtex merged commit 805704e into main Jan 16, 2026
4 checks passed
@thewtex thewtex deleted the fix-latex2e-compliance branch January 16, 2026 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:Appendices Issues affecting the Appendices part area:Architecture Issues affecting the Architecture part area:Cover Issues affecting the Cover area:DesignAndFunctionality Issues affecting the Design And Functionality part area:DevelopmentGuidelines Issues affecting the Development Guidelines part area:Examples Issues affecting the ITK Examples scraper area:Introduction Issues affecting the Introduction part language:LaTeX Changes to LaTeX code type:Artwork Changes to artwork files type:BookStyle Changes to book style files type:Infrastructure

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants