Modernize code #96
Open
Modernize code #96
+263
−365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sukhwinder33445
force-pushed
the
modernize-code
branch
2 times, most recently
from
eefa5b5 to
8686b59
Compare
Contributor
|
The |
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
db90247 to
204a7aa
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
21ca328 to
c248141
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
3 times, most recently
from
589584f to
c0df0ec
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
ef5f5f3 to
9b2ebce
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
9b2ebce to
9fc16d4
Compare
Contributor
|
The rest looks good. |
BastianLedererIcinga
force-pushed
the
modernize-code
branch
from
c0df0ec to
e1a3680
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
e1a3680 to
8bee499
Compare
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
from
9fc16d4 to
be685ed
Compare
sukhwinder33445
force-pushed
the
modernize-code
branch
from
8bee499 to
891337c
Compare
BastianLedererIcinga
previously approved these changes
Dec 11, 2025
BastianLedererIcinga
force-pushed
the
support-php-8.4/8.5
branch
2 times, most recently
from
2ebbbb8 to
9aaf2fd
Compare
lippserd
dismissed
BastianLedererIcinga’s stale review
The base branch was changed.
- Use [] instead of list()
- This was only introduced to reduce phpstan errors.
- Remove now obsolete throw annotation and imports
sukhwinder33445
force-pushed
the
modernize-code
branch
from
214e28b to
d8c9e53
Compare
BastianLedererIcinga
previously approved these changes
Jan 8, 2026
Contributor
BastianLedererIcinga
left a comment
BastianLedererIcinga
left a comment
There was a problem hiding this comment.
Local unit tests all pass when using the other modernize branches.
sukhwinder33445
force-pushed
the
modernize-code
branch
from
2d8f6f2 to
d8c9e53
Compare
Contributor
Author
|
Tests will pass once Icinga/ipl-stdlib#63 is merged. |
Contributor
Author
|
This PR introduces some breaking changes which should be reverted, such as changes to interfaces, base classes, or classes that may be extended. Could one of you please take over? @BastianLedererIcinga @Jan-Schuppik |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modernize and clean up the codebase by adopting the latest PHP features and functions.
Changes made:
InAndNotInUtilstrait, as it was only introduced to reduce phpstan errors