Standardize logging: Remove manual prefixes #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ger format Uses record.target() in the logger to automatically include module names in brackets, eliminating inconsistent manual prefixes that caused duplicate context like '[proxy] proxy: message'.
ChristianPavilonis
approved these changes
Jan 23, 2026
aram356
requested changes
Jan 26, 2026
| let ct_for_log: &str = if ct_raw.is_empty() { "-" } else { &ct_raw }; | ||
| log::info!( | ||
| "proxy(stream): origin response status={} ct={} cl={} accept={} url={}", | ||
| "stream: origin response status={} ct={} cl={} accept={} url={}", |
| "[Gzip->None] Decompressed size: {} bytes", | ||
| decompressed.len() | ||
| ); | ||
| log::info!("Gzip->None decompressed size: {} bytes", decompressed.len()); |
Collaborator
There was a problem hiding this comment.
⛏️ Change to Decompressed size
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize logging: Remove manual prefixes, add module target to logger format
Uses record.target() in the logger to automatically include module names in brackets, eliminating inconsistent manual prefixes that caused duplicate context like "[proxy] proxy: message".
closes #184