Skip to content

Allow to specify multiple Prebid script handlers #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aram356 wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Allow to specify multiple Prebid script handlers #169

aram356 wants to merge 4 commits into from

Conversation

@aram356
Copy link
Collaborator

@aram356 aram356 commented Jan 13, 2026

Closes #168

@aram356 aram356 marked this pull request as draft January 13, 2026 20:59
@aram356 aram356 self-assigned this Jan 22, 2026
@aram356 aram356 marked this pull request as ready for review January 22, 2026 16:33
ChristianPavilonis
ChristianPavilonis requested changes Jan 23, 2026
View reviewed changes
Copy link
Collaborator

@ChristianPavilonis ChristianPavilonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty good, what do you think of the Error/404 comment?

crates/common/src/integrations/prebid.rs
// - Exact paths like "/prebid.min.js" match only that path
// - Wildcard paths like "/static/prebid/*" match anything under that prefix
// and are filtered by PREBID_SCRIPT_SUFFIXES in matches_script_pattern()
vec![
Copy link
Collaborator

@ChristianPavilonis ChristianPavilonis Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔧 Could do the following to avoid duplication:

fn default_script_patterns() -> Vec<String> {
    PREBID_SCRIPT_SUFFIXES.iter().map(|&s| s.to_owned()).collect()
}

crates/common/src/integrations/prebid.rs
self.handle_third_party_ad(settings, req).await
}
// Serve empty JS for matching script patterns
Method::GET if self.matches_script_pattern(&path) => self.handle_script_handler(),
Copy link
Collaborator

@ChristianPavilonis ChristianPavilonis Jan 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Should we error or respond with a 404?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChristianPavilonis ChristianPavilonis ChristianPavilonis requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@aram356 aram356

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

As publisher I would like to configure many prebid script handlers

3 participants

@aram356 @ChristianPavilonis