Skip to content

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Jan 25, 2026

Resolves #5135
界面参考自 PrismLauncher
image
image

@CiiLu CiiLu marked this pull request as ready for review January 25, 2026 11:56
@3gf8jv4dv
Copy link
Contributor

界面撑的太大了,标题栏不好点、拖动。

Image

@3gf8jv4dv
Copy link
Contributor

「复制链接并打开浏览器」我只看到了浏览器出现,但剪贴板没有新的东西。

CiiLu and others added 2 commits January 25, 2026 20:56
Co-authored-by: 3gf8jv4dv <3gf8jv4dv@gmail.com>
@WhatDamon
Copy link
Contributor

此 PR 若未添加 OAuth 信息,可能会导致进入此界面后无法退出当前对话框
截屏2026-01-25 21 59 52

请考虑像 #5297 添加一个警告信息,并提供按钮能够让用户返回

@WhatDamon
Copy link
Contributor

注意到 Prism Launcher 的逻辑是二维码包含登录所需的代码,内容为 https://www.microsoft.com/link?otc={登录代码},而本 PR 的二维码则用于快速打开 https://www.microsoft.com/link

如果要比较,Prism Launcher 的体验相对会更好,但如果 HMCL 也这么干,则需要引入一个二维码生成库例如 ZXing (Apache 2.0) 或者 nayuki/QR-Code-generator (MIT) ,是否有必要在这一方面进行取舍 🤔

@Glavo
Copy link
Member

Glavo commented Jan 26, 2026

注意到 Prism Launcher 的逻辑是二维码包含登录所需的代码,内容为 https://www.microsoft.com/link?otc={登录代码},而本 PR 的二维码则用于快速打开 https://www.microsoft.com/link

如果要比较,Prism Launcher 的体验相对会更好,但如果 HMCL 也这么干,则需要引入一个二维码生成库例如 ZXing (Apache 2.0) 或者 nayuki/QR-Code-generator (MIT) ,是否有必要在这一方面进行取舍 🤔

可以分成两步实现,这个 PR 先专心更新到授权代码流,其他部分我之后研究一下。二维码库我之前就在考虑引入了。

@3gf8jv4dv
Copy link
Contributor

3gf8jv4dv commented Jan 26, 2026

microsoft_login.png 可以用 optipng 进一步压缩。
我试了下,参数 optipng -o7 -zm1-9 -strip all <filepath> 可以从 2,303 字节压到 701 字节。

Comment on lines +128 to 130
account.methods.microsoft.manual=If the website fails to load, please visit %s manually in your browser.\n\
\n\
<b>If your internet connection is bad, it may cause web pages to load slowly or fail to load altogether. You may try again later or switch to a different internet connection.</b>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
account.methods.microsoft.manual=If the website fails to load, please visit %s manually in your browser.\n\
\n\
<b>If your internet connection is bad, it may cause web pages to load slowly or fail to load altogether. You may try again later or switch to a different internet connection.</b>
account.methods.microsoft.manual=<b>If your internet connection is bad, it may cause web pages to load slowly or fail to load altogether.\nYou may try again later or switch to a different internet connection.</b>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature] 优化微软登录流程

4 participants