Skip to content

fix: 修复 JFXPopup 在 RTL 下漂移的问题 #5328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
CiiLu wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: 修复 JFXPopup 在 RTL 下漂移的问题 #5328

CiiLu wants to merge 2 commits into from

Conversation

@CiiLu
Copy link
Contributor

@CiiLu CiiLu commented Jan 25, 2026

@Glavo Glavo requested a review from Copilot January 25, 2026 07:29
Copilot AI reviewed Jan 25, 2026
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the JFXPopup positioning drift issue when the application is in RTL (Right-to-Left) mode, which is necessary to support RTL languages like Arabic. The fix ensures popups are correctly positioned and anchored in RTL layouts.

Changes:

  • Added RTL detection and handling to the JFXPopup show method
  • Implemented a helper method to flip horizontal position values for RTL mode
  • Adjusted popup positioning logic to account for RTL text direction

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@CiiLu