Fix #5321 : 部分情况下主页面版本图标不会同步 #5324
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR ensures that version icon changes are properly propagated so that the main page’s version icon stays in sync with updates made in the version settings UI.
Changes:
- Replaces the wildcard
org.jackhuang.hmcl.game.*import with specific class imports and adds imports forImage,Event, andJavaRuntimeused in the updated logic. - Enhances
loadVersioninVersionSettingsPageto capture the previously loaded version ID and icon and, when reloading the same version, fireonVersionIconChangedif the repository’s icon image differs from the last displayed icon. - Updates
onDeleteIconto fireonVersionIconChangedafter deleting a custom icon and reloading the icon, so consumers likeGameAdvancedListItemrefresh the displayed icon.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.