Fix#4763 : JFXTabPane 指示器偏移 #5308
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Glavo
reviewed
Jan 24, 2026
Glavo
reviewed
Jan 24, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a tab indicator offset issue in JFXTabPane by introducing a corrected implementation of the JFXTabPaneSkin class. The change addresses issue #4763 related to tab indicator positioning.
Changes:
- Complete implementation of JFXTabPaneSkin class with tab selection animation and indicator positioning logic
- Addition of header container, tab content holders, and scroll controls for tab navigation
- Implementation of Material Design styling for tab panes with ripple effects
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| final double oldWidth = snapSizeX(lineWidth * oldScaleX); | ||
| final double oldTransX = snapPositionX(selectedTabLine.getTranslateX()); | ||
|
|
||
| final double newScaleX = newWidth / lineWidth; |
There was a problem hiding this comment.
The variable offsetStart is used but never defined or initialized in the runTimeline method or as a class field in HeaderContainer. This will cause a compilation error. If this should reference header.scrollOffset or another offset value, it needs to be properly defined.
Suggested change
| final double newScaleX = newWidth / lineWidth; | |
| final double newScaleX = newWidth / lineWidth; | |
| final double offsetStart = 0.0; |
| } else if ("GRAPHIC".equals(p)) { | ||
| tabText.setGraphic(tab.getGraphic()); | ||
| } else if ("TOOLTIP".equals(p)) { | ||
| // install new Toolip/ uninstall the old one |
There was a problem hiding this comment.
Corrected spelling of 'Toolip' to 'Tooltip'.
Suggested change
| // install new Toolip/ uninstall the old one | |
| // install new Tooltip / uninstall the old one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4763
https://github.com/sshahine/JFoenix/blob/master/jfoenix/src/main/java/com/jfoenix/skins/JFXTabPaneSkin.java