扫描子目录时忽略 .connector 文件夹
#5296
扫描子目录时忽略 .connector 文件夹
#5296
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request fixes an issue where the Sinytra Connector mod creates a .connector folder in the mods directory, which was being incorrectly scanned as a mod subdirectory. The fix excludes the .connector folder from subdirectory scanning during mod management operations.
Changes:
- Added logic to skip the
.connectorfolder when scanning mod subdirectories for Forge/Quilt loaders
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try (DirectoryStream<Path> modsDirectoryStream = Files.newDirectoryStream(getModsDirectory())) { | ||
| for (Path subitem : modsDirectoryStream) { | ||
| if (supportSubfolders && Files.isDirectory(subitem)) { | ||
| if (supportSubfolders && Files.isDirectory(subitem) && !".connector".equalsIgnoreCase(subitem.getFileName().toString())) { |
There was a problem hiding this comment.
The hardcoded string ".connector" should be extracted as a constant, similar to how DISABLED_EXTENSION and OLD_EXTENSION are defined at the class level (lines 382-383). This would improve maintainability and make it easier to find and update if needed. Consider defining it as:
public static final String CONNECTOR_FOLDER = ".connector";
Then use it in the condition. Note that this same folder is already referenced in ModAdviser.java line 67 in the MODPACK_BLACK_LIST, which further suggests it should be a shared constant.
1 participant
#5285
测试发现 kilt 没有类似的行为