Skip to content

Conversation

@dhavalbhensdadiya-crest
Copy link

@dhavalbhensdadiya-crest dhavalbhensdadiya-crest commented Jan 21, 2026

Description

Add new samples in global and regional scope for below operations:

  1. Create secret with Customer Managed Encryption Key
  2. Delete secret annotations

Fixes #

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • These samples need a new API enabled in testing projects to pass (let us know which ones) - Cloud KMS API
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones) - GOOGLE_CLOUD_REGIONAL_KMS_KEY, GOOGLE_CLOUD_KMS_KEY
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@snippet-bot
Copy link

snippet-bot bot commented Jan 21, 2026

Here is the summary of changes.

You are about to add 4 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: secretmanager Issues related to the Secret Manager API. labels Jan 21, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the Google Cloud Secret Manager Java samples by adding new functionalities for managing secrets with Customer Managed Encryption Keys (CMEK) and for manipulating secret annotations. These additions provide developers with clear examples for advanced secret management operations, ensuring better security and organizational control over sensitive data. The changes are accompanied by comprehensive documentation updates and robust integration tests to maintain code quality and reliability.

Highlights

  • New Samples for Customer Managed Encryption Keys (CMEK): Introduced new code samples demonstrating how to create secrets with Customer Managed Encryption Keys (CMEK) in both global and regional scopes for Google Cloud Secret Manager.
  • New Samples for Deleting Secret Annotations: Added new code samples for deleting annotations from existing secrets, covering both global and regional Secret Manager configurations.
  • Documentation Updates: The README.md file has been updated to include instructions for enabling the Cloud KMS API, setting new environment variables for global and regional KMS keys, and granting the necessary Cloud KMS Encrypter / Decrypter IAM role.
  • Integration Test Coverage: New integration tests have been added and existing test files modified to validate the functionality of creating secrets with CMEK and deleting secret annotations for both global and regional scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds new samples for creating secrets with Customer-Managed Encryption Keys (CMEK) and for deleting secret annotations, for both global and regional secrets. The changes include updates to the README, new sample files, and corresponding integration tests. My review focuses on improving the clarity and efficiency of the new sample code. I've pointed out some incorrect comments and region tags in CreateSecretWithCmek.java that seem to be from a copy-paste. I've also suggested a more efficient implementation for DeleteSecretAnnotations.java and its regional counterpart, which avoids an unnecessary API call.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: secretmanager Issues related to the Secret Manager API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant