-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Added new samples for CMEK and Annotations #10223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Added new samples for CMEK and Annotations #10223
Conversation
…ion key and deleting annotations from the secret
|
Here is the summary of changes. You are about to add 4 region tags.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @dhavalbhensdadiya-crest, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly expands the Google Cloud Secret Manager Java samples by adding new functionalities for managing secrets with Customer Managed Encryption Keys (CMEK) and for manipulating secret annotations. These additions provide developers with clear examples for advanced secret management operations, ensuring better security and organizational control over sensitive data. The changes are accompanied by comprehensive documentation updates and robust integration tests to maintain code quality and reliability. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds new samples for creating secrets with Customer-Managed Encryption Keys (CMEK) and for deleting secret annotations, for both global and regional secrets. The changes include updates to the README, new sample files, and corresponding integration tests. My review focuses on improving the clarity and efficiency of the new sample code. I've pointed out some incorrect comments and region tags in CreateSecretWithCmek.java that seem to be from a copy-paste. I've also suggested a more efficient implementation for DeleteSecretAnnotations.java and its regional counterpart, which avoids an unnecessary API call.
secretmanager/src/main/java/secretmanager/CreateSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/CreateSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/CreateSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/CreateSecretWithCmek.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/DeleteSecretAnnotations.java
Outdated
Show resolved
Hide resolved
secretmanager/src/main/java/secretmanager/regionalsamples/DeleteRegionalSecretAnnotations.java
Outdated
Show resolved
Hide resolved
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Description
Add new samples in global and regional scope for below operations:
Fixes #
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only