fix: allow selecting multiple users with comma in Reports tab search #80437
+125
−60
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Change
The Reports tab uses
SearchPageHeaderInput.tsxfor its search input, while the Inbox tab usesSearchRouter.tsx. The comma handling logic for selecting multiple users was only inSearchRouter.tsx, causing the Reports tab to replace the first user instead of adding to the list when selecting a second user after typing a comma.This PR:
getTrimmedUserSearchQueryPreservingComma()inSearchAutocompleteUtils.tsthat handles comma-separated value preservation for "name fields" (to, from, assignee, payer, exporter, attendee)SearchPageHeaderInput.tsxto use this function (the actual fix)SearchRouter.tsxandSearchAutocompleteList.tsxto use the same shared function, eliminating code duplicationFixed Issues
$ #79695
PROPOSAL: #79695 (comment)
Tests
to:user1,user2)Offline tests
N/A - This is a UI interaction fix that doesn't involve network requests.
QA Steps
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari