[NO QA] Update setup task to match in-product wording #80384
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently changed the section header from `Add approvals` to just `Approvals`, so updating here!
melvin-bot
bot
requested review from
mjasikowski and
trjExpensify
and removed request for
a team
|
@mjasikowski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Contributor
Author
|
I know we still need translations, but I believe engineering has a way to do them faster. @mjasikowski is it possible for you to help with that part? |
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index a4b3fbf2..950cd07b 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -2610,7 +2610,7 @@ ${amount} für ${merchant} – ${date}`,
title: 'Spesengenehmigungen hinzufügen',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- *Fügen Sie Ausgabengenehmigungen hinzu*, um die Ausgaben Ihres Teams zu prüfen und unter Kontrolle zu halten.
+ *Fügen Sie Ausgabengenehmigungen hinzu*, um die Ausgaben Ihres Teams zu überprüfen und unter Kontrolle zu halten.
So geht's:
@@ -2618,9 +2618,9 @@ ${amount} für ${merchant} – ${date}`,
2. Wählen Sie Ihren Workspace aus.
3. Klicken Sie auf *More features*.
4. Aktivieren Sie *Workflows*.
- 5. Navigieren Sie im Workspace-Editor zu *Workflows*.
- 6. Aktivieren Sie *Add approvals*.
- 7. Sie werden als Genehmiger für Ausgaben festgelegt. Sie können dies auf jeden Administrator ändern, sobald Sie Ihr Team eingeladen haben.
+ 5. Navigieren Sie zu *Workflows* im Workspace-Editor.
+ 6. Aktivieren Sie *Approvals*.
+ 7. Sie werden als Genehmiger für Ausgaben festgelegt. Sie können dies auf einen beliebigen Admin ändern, sobald Sie Ihr Team eingeladen haben.
[Zu More features wechseln](${workspaceMoreFeaturesLink}).`),
},
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index b89785f3..2599f1b0 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -2619,15 +2619,15 @@ ${amount} pour ${merchant} - ${date}`,
Voici comment faire :
- 1. Allez dans *Espaces de travail*.
+ 1. Accédez à *Workspaces*.
2. Sélectionnez votre espace de travail.
- 3. Cliquez sur *Plus de fonctionnalités*.
+ 3. Cliquez sur *More features*.
4. Activez *Workflows*.
- 5. Accédez à *Workflows* dans l’éditeur de l’espace de travail.
- 6. Activez *Ajouter des validations*.
+ 5. Allez à *Workflows* dans l’éditeur d’espace de travail.
+ 6. Activez *Approvals*.
7. Vous serez défini comme valideur des dépenses. Vous pourrez changer cela pour n’importe quel administrateur une fois que vous aurez invité votre équipe.
- [Accéder aux fonctionnalités supplémentaires](${workspaceMoreFeaturesLink}).`),
+ [Faites-moi découvrir plus de fonctionnalités](${workspaceMoreFeaturesLink}).`),
},
createTestDriveAdminWorkspaceTask: {
title: ({workspaceConfirmationLink}) => `[Créer](${workspaceConfirmationLink}) un espace de travail`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index ce077164..9ab44624 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -2605,17 +2605,17 @@ ${amount} per ${merchant} - ${date}`,
title: 'Aggiungi approvazioni delle spese',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- *Aggiungi approvazioni delle spese* per rivedere le spese del tuo team e tenerle sotto controllo.
+ *Aggiungi le approvazioni delle spese* per rivedere le spese del tuo team e mantenerle sotto controllo.
- Procedi così:
+ Ecco come fare:
- 1. Vai su *Spazi di lavoro*.
+ 1. Vai a *Spazi di lavoro*.
2. Seleziona il tuo spazio di lavoro.
3. Fai clic su *Altre funzionalità*.
4. Abilita *Flussi di lavoro*.
5. Vai a *Flussi di lavoro* nell’editor dello spazio di lavoro.
- 6. Abilita *Aggiungi approvazioni*.
- 7. Verrai impostato come approvatore delle spese. Puoi modificarlo in qualsiasi amministratore dopo aver invitato il tuo team.
+ 6. Abilita *Approvazioni*.
+ 7. Verrai impostato come approvatore delle spese. Puoi cambiarlo in qualsiasi amministratore dopo aver invitato il tuo team.
[Portami alle altre funzionalità](${workspaceMoreFeaturesLink}).`),
},
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 197488a8..0cbca37e 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -2596,19 +2596,19 @@ ${merchant} への ${amount}（${date}）`,
title: '経費承認を追加',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- チームの支出を確認して管理するには、*経費承認を追加* してください。
+ チームの支出を確認し、コントロールするために、*経費承認を追加* しましょう。
手順は次のとおりです：
- 1. *Workspaces* に移動します。
+ 1. *ワークスペース* に移動します。
2. ワークスペースを選択します。
- 3. *More features* をクリックします。
- 4. *Workflows* を有効にします。
- 5. ワークスペースエディタで *Workflows* に移動します。
- 6. *Add approvals* を有効にします。
- 7. チームを招待すると、あなたが経費承認者として設定されます。これは、任意の管理者に変更できます。
+ 3. *その他の機能* をクリックします。
+ 4. *ワークフロー* を有効にします。
+ 5. ワークスペースエディタ内の *ワークフロー* に移動します。
+ 6. *承認* を有効にします。
+ 7. あなたが経費の承認者として設定されます。チームを招待した後は、任意の管理者に変更できます。
- [More features へ移動する](${workspaceMoreFeaturesLink})。`),
+ [その他の機能に移動](${workspaceMoreFeaturesLink})。`),
},
createTestDriveAdminWorkspaceTask: {
title: ({workspaceConfirmationLink}) => `ワークスペースを[作成](${workspaceConfirmationLink})`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index f778ac97..114cc3d5 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -2603,19 +2603,19 @@ ${amount} voor ${merchant} - ${date}`,
title: 'Uitgaven goedkeuringen toevoegen',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- *Uitgavegoedkeuringen toevoegen* om de uitgaven van je team te beoordelen en onder controle te houden.
+ *Voeg uitgavenfiattering toe* om de uitgaven van je team te beoordelen en onder controle te houden.
- Dit doe je zo:
+ Zo doe je dat:
1. Ga naar *Workspaces*.
2. Selecteer je workspace.
- 3. Klik op *More features*.
+ 3. Klik op *Meer functies*.
4. Schakel *Workflows* in.
5. Ga naar *Workflows* in de workspace-editor.
- 6. Schakel *Add approvals* in.
- 7. Jij wordt ingesteld als de goedkeurder van uitgaven. Je kunt dit wijzigen naar elke beheerder zodra je je team hebt uitgenodigd.
+ 6. Schakel *Fiatteringen* in.
+ 7. Jij wordt ingesteld als de fiatteur voor uitgaven. Je kunt dit wijzigen naar elke beheerder zodra je je team uitnodigt.
- [Breng me naar more features](${workspaceMoreFeaturesLink}).`),
+ [Breng me naar Meer functies](${workspaceMoreFeaturesLink}).`),
},
createTestDriveAdminWorkspaceTask: {
title: ({workspaceConfirmationLink}) => `[Maak](${workspaceConfirmationLink}) een workspace`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 8e45fc31..3d71a98d 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -2596,19 +2596,19 @@ ${amount} dla ${merchant} - ${date}`,
title: 'Dodaj zatwierdzanie wydatków',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- *Dodaj zatwierdzanie wydatków*, aby przeglądać wydatki swojego zespołu i mieć je pod kontrolą.
+ *Dodaj zatwierdzanie wydatków*, aby przeglądać wydatki zespołu i utrzymać je pod kontrolą.
Oto jak:
1. Przejdź do *Workspaces*.
- 2. Wybierz swoją przestrzeń roboczą.
+ 2. Wybierz swój workspace.
3. Kliknij *More features*.
4. Włącz *Workflows*.
- 5. Przejdź do *Workflows* w edytorze przestrzeni roboczej.
- 6. Włącz *Add approvals*.
- 7. Zostaniesz ustawiony jako osoba zatwierdzająca wydatki. Po zaproszeniu zespołu możesz zmienić to na dowolnego administratora.
+ 5. Przejdź do *Workflows* w edytorze workspace.
+ 6. Włącz *Approvals*.
+ 7. Zostaniesz ustawiony jako zatwierdzający wydatki. Po zaproszeniu zespołu możesz zmienić tę osobę na dowolnego administratora.
- [Przejdź do more features](${workspaceMoreFeaturesLink}).`),
+ [Przejdź do More features](${workspaceMoreFeaturesLink}).`),
},
createTestDriveAdminWorkspaceTask: {
title: ({workspaceConfirmationLink}) => `[Utwórz](${workspaceConfirmationLink}) przestrzeń roboczą`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index b3ff62c0..ae41c52c 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -2600,15 +2600,15 @@ ${amount} para ${merchant} - ${date}`,
Veja como:
- 1. Vá para *Workspaces*.
- 2. Selecione seu workspace.
- 3. Clique em *More features*.
+ 1. Vá para *Espaços de trabalho*.
+ 2. Selecione seu espaço de trabalho.
+ 3. Clique em *Mais recursos*.
4. Ative *Workflows*.
- 5. Acesse *Workflows* no editor do workspace.
- 6. Ative *Add approvals*.
- 7. Você será definido como aprovador de despesas. Você pode alterar isso para qualquer administrador depois de convidar sua equipe.
+ 5. Acesse *Workflows* no editor do espaço de trabalho.
+ 6. Ative *Approvals*.
+ 7. Você será definido como o aprovador de despesas. Você pode alterar isso para qualquer administrador depois de convidar sua equipe.
- [Levar-me para mais recursos](${workspaceMoreFeaturesLink}).`),
+ [Leve-me para mais recursos](${workspaceMoreFeaturesLink}).`),
},
createTestDriveAdminWorkspaceTask: {
title: ({workspaceConfirmationLink}) => `[Crie](${workspaceConfirmationLink}) um workspace`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 71c8fc3a..0d427b96 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -2556,17 +2556,17 @@ ${amount}，商户：${merchant} - ${date}`,
title: '添加报销审批',
description: ({workspaceMoreFeaturesLink}) =>
dedent(`
- *添加报销审批*，以便审核团队支出并保持支出可控。
+ *添加报销审批*，以便审核团队支出并将其控制在合理范围内。
操作步骤如下：
- 1. 进入 *工作区*。
+ 1. 进入 *Workspaces*。
2. 选择你的工作区。
- 3. 点击 *更多功能*。
- 4. 启用 *工作流*。
- 5. 在工作区编辑器中前往 *工作流*。
- 6. 启用 *添加审批*。
- 7. 你将被设为报销审批人。邀请团队成员后，你可以将其更改为任何管理员。
+ 3. 点击 *More features*。
+ 4. 启用 *Workflows*。
+ 5. 在工作区编辑器中进入 *Workflows*。
+ 6. 启用 *Approvals*。
+ 7. 你将被设为报销审批人。邀请团队成员后，你可以将此角色更改为任何管理员。
[带我前往更多功能](${workspaceMoreFeaturesLink})。`),
},
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Code Review Summary✅ Inline Review Complete - No code violations found. The change correctly updates the English text from "Add approvals" to "Approvals" to match the current in-product UI wording. Note on Spanish TranslationThe corresponding Spanish translation in |
mjasikowski
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently changed the section header from
Add approvalsto justApprovals, so updating here!Explanation of Change
Fixed Issues
$
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari