splice: Enable cross splice in script #8450
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
4 times, most recently
from
3f5ce3e to
a8b6647
Compare
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
from
bcf603c to
858ca51
Compare
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
2 times, most recently
from
ac2e3b1 to
b072bbb
Compare
Turns on mutli channel splices in splice script and adds a test for it. Changelog-Changed: Splice script now supports splicing over multiple channels
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
3 times, most recently
from
3c71acb to
4b44e19
Compare
`bitcoin_tx_input_weight` already adds the prefix byte for counting the witness items
In splicing logs we’re often outputting msat values next to sat values, making understanding the logs difficult. Adding a way to output msats as sats with a decimal makes these logs much easier to read.
Since channeld handles splicing, it makes sense that it knows the opening feerate now. This is needed for rounding out splice script errors and logging.
On the rare chance a channel id starts with 02 or 03 we need to check of it’s referring to a channel before parsing it node id, instead of after.
Here we update `psbt_input_get_weight` to allow the caller to specify what kind of input size estimation they would like. Before it was just “zero witness bytes” which we now move to the default behavior and add an assumption option for P2WSH -> 2of2 multisig which is what we typically see in splicing. At the same time we move channeld over to using the opening feerate estimation instead of the less useful “max feerate.” We make splice script use this same feerate. After auditing the feerates for these two places against each other and the actually created transaction, we implement some fixes making them all match. While we’re here, we add relevant debug log messages. Changelog-Changed: Audited and updated splice’s feerate calculations to be precise to the byte — a critical change to accomodate splice script.
When using wetlog we might not also have debug log enabled.
In some splice script failure modes, some memory is leaked. These don’t occur in normal operation — just when an error occurs. This cleans up those memory leaks.
Enable feerate checks for the test now that they’re working well
Work is still in progress!
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
7 times, most recently
from
fca6294 to
a1c8215
Compare
ddustin
force-pushed
the
ddustin/cross_splice_script
branch
from
a1c8215 to
89e3067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable cross channel splices in splice script