-
Notifications
You must be signed in to change notification settings - Fork 31
ci: add Codecov #3237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
ci: add Codecov #3237
Conversation
|
View your CI Pipeline Execution ↗ for commit 68858a2 ☁️ Nx Cloud last updated this comment at |
- we're just using the default coverageReporters: https://jestjs.io/docs/configuration#coveragereporters-arraystring--string-options - the base config is using the preset, so we only need to declare reporters in one place - 'summary' is an invalid reporter - we want to always include the github-actions reporter in CI
these are different from the reporters
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
- nx run-many instead of nx affected to guarantee main tests always reflect the whole repo - differentiate between PRs and main coverage with tags
use latest ubuntu LTS version
from https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request: > By default, a workflow only runs when a pull_request event's activity type is opened, synchronize, or reopened.
|
🚀 Styleguide deploy preview ready! Preview URL: https://6973b0995a185c4bd39ca5f0--gamut-preview.netlify.app |
This adds Codecov to Gamut, including an initial codecov.yml config, coverage reporting, and their new test analytics so we can try it out.
Note that it only runs for PRs so we can test it. It should result in a report at https://app.codecov.io/gh/Codecademy/gamut/. If it works, I'll add it for the full repo.I also made a few optimizations to the test workflow:
24.04) (fd83cc5)if: ${{ !cancelled() }}overif: always(): https://docs.github.com/en/actions/reference/workflows-and-actions/expressions#always (68858a2)pull_request.typesarray since it's just the default triggers (a2cc842)PR Checklist