London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls #923

Grajales-K · 2026-01-05T16:12:16Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

In this project, we built a semantic and accessible HTML form designed to verify returning customers and collect their t-shirt preferences.

Questions

no

-notes.md to make notes about the project -style.css file

-title -form -first fieldset for colors

-file img - favicon img

-link meta for favicon -img file

-fieldset password because we still can validate name and email

-legend for costomer details -corrected name in the li yellow

netlify · 2026-01-05T16:12:21Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`a7603e9`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/696c2a009d8ba70008adb4db
😎 Deploy Preview	https://deploy-preview-923--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 88 (🟢 up 2 from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

jenny-alexander

👏 Your t-shirt order form was well done and met all of the exercise requirements. Nice work!
I left a few comments for you to review.

jenny-alexander · 2026-01-15T04:40:02Z

Form-Controls/index.html

+        <fieldset class="user-details">
+          <legend><strong>Customer Member Details</strong></legend>
+          <div class="form-control">
+            <label for="Username">User Name</label>


There is a small error here related to the <label> and <input> elements. Can you find it?

@jenny-alexander, Yes, I mixed up the capital letters, and I fixed the "username" <label>and <input>.

jenny-alexander · 2026-01-15T04:40:40Z

Form-Controls/index.html

+            <option value="M">M</option>
+            <option value="L">L</option>
+            <option value="XL">XL</option>
+            <option value="xXL">XL</option>


Small error here in your XL option.

thanks, I fixed it.

😄 I can see you fixed the value for the last size option. However, if you take a closer look, you will see there is something that needs to be fixed concerning the sizes displayed to the user.
Can you find it?

@jenny-alexander ohh nooo 🫣 yes I saw it now! thank you. I fixed it again.

jenny-alexander · 2026-01-15T04:44:03Z

Form-Controls/index.html

+    </div>
+  </main>
+  <footer>
+    <h2>By Karla Grajales</h2>


🤔 Considering using a different HTML element for your name within the footer. Right now, having <h2> in the footer will signal to screen readers that there is something new and important in the footer. In a sense, it breaks the semantic order of the page.

Thank you very much @jenny-alexander for your kind review, I addressed all your commets I hope they are now ok.❤️

Grajales-K · 2026-01-16T21:52:04Z

Hi @jenny-alexander, I've noticed that some hash commits have a green tick while others do not. What is the difference between them? Thank you.

jenny-alexander · 2026-01-17T22:58:04Z

Hi @jenny-alexander, I've noticed that some hash commits have a green tick while others do not. What is the difference between them? Thank you.

That's a good question @Grajales-K! A red 'x' next to a hash commit means that one or more GitHub Actions failed.

Usually, a failure will show up in this section of the PR:

If the failed hash is in the past, you can click on it and navigate a bit further to see why it failed.
This one (in the video recording) looks like it most likely failed because it's missing a submit label? The GitHub Actions on subsequent hash commits finished successfully.
If a GitHub action keeps failing and prevents you from going further you would have to read the error message, figure out what it means and/or ask for help from team members!. (i.e. At my work, all GitHub actions have to pass successfully before I can merge a PR to the main branch),

Screen.Recording.2026-01-17.at.4.41.22.PM.mov

Grajales-K · 2026-01-18T00:37:04Z

Hi @jenny-alexander,
Yes, I was working for four hours figuring out the failed meta, which was failing because of the label. Thank you so much.

I have some doubts; from these three commits, only one has the green tick.

Grajales-K added 18 commits January 1, 2026 22:11

New branch done and title of the page in html

31b45e7

removed meta instruction unused

d4751b0

added

5c6194f

-notes.md to make notes about the project -style.css file

added:

c26d36d

-title -form -first fieldset for colors

added fieldset user details

2933319

added fieldset for size

f092d32

added fieldset date and button submit form

1e4d266

update description in the meta

8d4e339

notes

bea249d

added

bb8181e

-file img - favicon img

removed

a5df516

-link meta for favicon -img file

removed notes.md no required

76b259e

removed file style.css because no style is required

cf383d6

removed

6d1a7c3

-fieldset password because we still can validate name and email

updated

170708c

-legend for costomer details -corrected name in the li yellow

updated the place holder in the user Name

f7ed400

removed delivery pick date, no in the requiments

6dc97e0

cleaning some classes unused

08583cd

Grajales-K added 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Onboarding The name of the module. labels Jan 5, 2026

Grajales-K added 2 commits January 5, 2026 20:00

removed spaces

b767b75

check accessibility 100%

d43bed7

Grajales-K removed the ⚙️ bug Something isn't working label Jan 5, 2026

Grajales-K mentioned this pull request Jan 6, 2026

Form Controls Grajales-K/My-Coursework-Planner#22

Open

3 tasks

added a extra option selector

adc5fc2

jenny-alexander self-requested a review January 14, 2026 13:06

jenny-alexander added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 14, 2026

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 15, 2026

jenny-alexander reviewed Jan 15, 2026

View reviewed changes

jenny-alexander added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Jan 15, 2026

Grajales-K added 3 commits January 16, 2026 21:28

fix: correct label casing for username input field

0883d82

fix: correct label for size option in form options

52aced1

fix: the footer for better readability and SEO.

9a4b7bb

Grajales-K requested a review from jenny-alexander January 16, 2026 21:52

Grajales-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 16, 2026

jenny-alexander removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 17, 2026

fix: correct label for XXL size option in form

a7603e9

Grajales-K added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 18, 2026

Uh oh!

London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls #923

Are you sure you want to change the base?

London | 26-ITP-January | Karla Grajales | Sprint 2 | Form Controls #923

Conversation

Grajales-K commented Jan 5, 2026

Learners, PR Template

Changelist

Questions

Uh oh!

netlify bot commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

jenny-alexander left a comment

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Grajales-K Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

Grajales-K Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

Grajales-K Jan 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jenny-alexander Jan 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Grajales-K Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

Grajales-K commented Jan 16, 2026

Uh oh!

jenny-alexander commented Jan 17, 2026

Uh oh!

Grajales-K commented Jan 18, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

netlify bot commented Jan 5, 2026 •

edited

Loading

Grajales-K Jan 16, 2026 •

edited

Loading

Grajales-K Jan 18, 2026 •

edited

Loading

jenny-alexander Jan 15, 2026 •

edited

Loading