-
Notifications
You must be signed in to change notification settings - Fork 0
[SSF 17] - environment variables updates #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSF 17] - environment variables updates #44
Conversation
Juwang110
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything lgtm!
sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
| This can be found next to your profile name when you login to the main page. Some accounts may be different, but we generally use us-east-1 or us-east-2 | ||
| This can be found next to your profile name when you login to the main page. Some accounts may be different, but we generally use us-east-1 or us-east-2. | ||
| This is the region that you find on the right side after clicking on the location dropdown, usually saying "United States (*some region*)". | ||
| For example, if we want to use Ohio as the region, we would put `AWS_REGION="us-east2"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing hyphen
ℹ️ Issue
Closes #17
📝 Description
Removed unnecessary environment variables and added proper documentation in the .env.example and README
✔️ Verification
Verified all tools utilizing AWS keys still worked. This included authenication (since this is branched off of #35) and delivery confirmation.
🏕️ (Optional) Future Work / Notes
We should make sure from here out, any environment updates get an updated README and .env.example in their PR