Skip to content

Conversation

@dzsquared
Copy link
Collaborator

Description

fixes #267

  • puts quotes around the database name going into sqlcmd calls
  • escapes quotes in a database name when being passed to sqlcmd

Code Changes

  • Unit tests are added, if possible
  • New or changed code follows the C# style guidelines defined in .editorconfig
  • All changes MUST be backwards compatible and changes to the shared az_func.GlobalState table must be compatible with all prior versions of the extension
  • Use core.debug or directly log to console to display relevant information
  • Use async and await for all long-running operations

Dependencies

  • If updating dependencies, run npm install to update the lock files and ensure that there are NO major versions updates or additional vulnerabilities in package-lock.json. If there are, contact the dev team for instructions.

Documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Database names with spaces cause firewall detection to fail - sqlcmd argument not quoted

2 participants