sqlite: bind ArrayBuffer

[mike-git374]

Problem

You can bind Buffer or TypedArray (added in #56384) but ArrayBuffer doesn't work:

import { DatabaseSync } from 'node:sqlite';

const db = new DatabaseSync(':memory:');

db.exec('create table t (c)');

const insert = db.prepare('insert into t values (?)');
const select = db.prepare('select * from t');

insert.run(new Uint8Array([ 1, 2, 3 ]));
insert.run(new Uint16Array([ 4, 5, 6 ]));
insert.run(new Uint8Array([ 7, 8, 9 ]).buffer); // ArrayBuffer
insert.run(Buffer.from([ 10, 11, 12 ]));

console.log(select.all());

// [
//   { c: Uint8Array(3) [ 1, 2, 3 ] },
//   { c: Uint8Array(6) [ 4, 0, 5, 0, 6, 0 ] },
//   { c: null },
//   { c: Uint8Array(3) [ 10, 11, 12 ] }
// ]

Related: Boolean should also be allowed to bind, see SQLite bind booleans

Proposal

Allow binding ArrayBuffer, either by directly handling ArrayBuffer if possible, or internally converting to Uint8Array if needed

insert.run(arrayBuffer);

Alternatives

Convert to Uint8Array or Buffer before binding, but this should not be required:

insert.run(Buffer.from(arrayBuffer));

insert.run(new Uint8Array(arrayBuffer));

[geeksilva97]

I don't know if that's possible.

ArrayBuffer is the underlying sequence of bytes. To get the valuues (needed for binding) of that sequence we need to add a view on top of it.

[mike-git374]

These primitive JS values like ArrayBuffer and Boolean with clear SQLite equivalents should not be throwing errors or silently failing, the driver should convert these as needed

[geeksilva97]

These primitive JS values like ArrayBuffer and Boolean with clear SQLite equivalents should not be throwing errors or silently failing, the driver should convert these as needed

I don't get it. To which of the views should an ArrayBuffer be converted to?

[mike-git374]

Uint8Array

[geeksilva97]

Uint8Array

why that one?

[mike-git374]

SQLite BLOB is a series of bytes, ArrayBuffer is also a series of bytes, if you need an ArrayBufferView you can take new Uint8Array(arrayBuffer) which is similar to Buffer.from(arrayBuffer). The SQLite BLOB should end up with the same series of bytes