From 4f24d6f178a023ca0c7118dbb4039b041d703ef9 Mon Sep 17 00:00:00 2001 From: Mika Jahnke Date: Thu, 22 Jan 2026 12:09:33 -0600 Subject: [PATCH 1/2] message updates --- nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py | 2 +- nodescraper/plugins/inband/bios/bios_analyzer.py | 6 +++++- nodescraper/plugins/inband/memory/memory_analyzer.py | 8 +++++++- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a/nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py b/nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py index 085f022f..d3db023f 100644 --- a/nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py +++ b/nodescraper/plugins/inband/amdsmi/amdsmi_analyzer.py @@ -286,7 +286,7 @@ def check_amdsmi_metric_ecc_totals(self, amdsmi_metric_data: list[AmdSmiMetric]) if count is not None and count > 0: self._log_event( category=EventCategory.RAS, - description=f"GPU: {gpu} has {desc}: {count}", + description="GPU ECC error count detected", priority=priority, data={"gpu": gpu, "error_count": count, "error_type": desc}, console_log=True, diff --git a/nodescraper/plugins/inband/bios/bios_analyzer.py b/nodescraper/plugins/inband/bios/bios_analyzer.py index ac03066f..cd11338f 100644 --- a/nodescraper/plugins/inband/bios/bios_analyzer.py +++ b/nodescraper/plugins/inband/bios/bios_analyzer.py @@ -86,7 +86,11 @@ def analyze_data( self.result.status = ExecutionStatus.ERROR self._log_event( category=EventCategory.BIOS, - description=f"{self.result.message}, Actual: {data.bios_version}", + description="Bios data mismatch", + data={ + "actual_bios_version": data.bios_version, + "expected_bios_version": args.exp_bios_version, + }, priority=EventPriority.ERROR, console_log=True, ) diff --git a/nodescraper/plugins/inband/memory/memory_analyzer.py b/nodescraper/plugins/inband/memory/memory_analyzer.py index 0db6c230..ec57218c 100644 --- a/nodescraper/plugins/inband/memory/memory_analyzer.py +++ b/nodescraper/plugins/inband/memory/memory_analyzer.py @@ -91,8 +91,14 @@ def _bytes_to_gb(n: float) -> float: self.result.status = ExecutionStatus.ERROR self._log_event( category=EventCategory.OS, - description=self.result.message, + description="Memory usage exceeds maximum allowed used memory", priority=EventPriority.CRITICAL, + data={ + "used_memory": used_memory, + "max_allowed_used_mem": max_allowed_used_mem, + "total_memory": total_memory, + "free_memory": free_memory, + }, ) return self.result From f2c20ca9ffe8f2d93b6aef0c2210e164bb135408 Mon Sep 17 00:00:00 2001 From: Mika Jahnke Date: Thu, 22 Jan 2026 13:02:53 -0600 Subject: [PATCH 2/2] changes undone --- nodescraper/plugins/inband/bios/bios_analyzer.py | 2 +- nodescraper/plugins/inband/memory/memory_analyzer.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/nodescraper/plugins/inband/bios/bios_analyzer.py b/nodescraper/plugins/inband/bios/bios_analyzer.py index cd11338f..a78f3158 100644 --- a/nodescraper/plugins/inband/bios/bios_analyzer.py +++ b/nodescraper/plugins/inband/bios/bios_analyzer.py @@ -86,7 +86,7 @@ def analyze_data( self.result.status = ExecutionStatus.ERROR self._log_event( category=EventCategory.BIOS, - description="Bios data mismatch", + description=f"{self.result.message}, Actual: {data.bios_version}", data={ "actual_bios_version": data.bios_version, "expected_bios_version": args.exp_bios_version, diff --git a/nodescraper/plugins/inband/memory/memory_analyzer.py b/nodescraper/plugins/inband/memory/memory_analyzer.py index ec57218c..49a8ab6b 100644 --- a/nodescraper/plugins/inband/memory/memory_analyzer.py +++ b/nodescraper/plugins/inband/memory/memory_analyzer.py @@ -91,7 +91,7 @@ def _bytes_to_gb(n: float) -> float: self.result.status = ExecutionStatus.ERROR self._log_event( category=EventCategory.OS, - description="Memory usage exceeds maximum allowed used memory", + description=self.result.message, priority=EventPriority.CRITICAL, data={ "used_memory": used_memory,