More Red cable rendering is broken with always-tesselate-blocks

[Lolothepro]

Minecraft version

1.21.1

Describe the bug

Enable always-tesselate-blocks and test the rendering of More Red cables.

Steps to reproduce

Place More Red cables

Logs

No response

Additional context

this happens because the wrong ModelData gets passed to children of MultiPartBakedModel, the root ModelData gets saved in BlockRenderer#renderModel, then the model and its children are traversed by fabric api's emitBlockQuads which doesn't handle ModelData

andrew

the bug causes the CaffeineMC/sodium#2906 & Commoble/morered#26

[PepperCode1]

To properly fix this, Forgified FRAPI should add a ModelData stack to the RenderContext and push/pop it accordingly inside of MultipartBakedModelMixin before/after calling emitBlockQuads on a submodel. RenderContext.getModelData would then return the current top-most element of the stack so that VanillaModelEncoder uses the correct ModelData.

[Vartis]

What are the chances of this being patched? I was surprised to see any updates on that post on morereds git well over a year later. It seemed nobody wanted to take credit for the issue and the morered dev had little interest in even attempting a backported fix.

[Lolothepro]

What are the chances of this being patched? I was surprised to see any updates on that post on morereds git well over a year later. It seemed nobody wanted to take credit for the issue and the morered dev had little interest in even attempting a backported fix.

MoreRed devs cannot fix the bug (except via a PR that fixes the bug on this repo).