From 98c49fc7fb341911e8ceb0116cfce1ec68c8eb20 Mon Sep 17 00:00:00 2001 From: Freddie Akeroyd Date: Sun, 27 Apr 2025 20:25:22 +0100 Subject: [PATCH 1/2] Fix race condition on initial value? --- test_genie_python_using_simple.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test_genie_python_using_simple.py b/test_genie_python_using_simple.py index 5a4339c..2b0da45 100644 --- a/test_genie_python_using_simple.py +++ b/test_genie_python_using_simple.py @@ -236,7 +236,9 @@ def setUp(self): self.wait_before = 1 self.wait_after = 2 self.max_wait = (self.wait_before + self.wait_after) * 2 - g.cset(self.block_name, 0) + initial_block_value = 0 + g.cset(self.block_name, initial_block_value) + g.waitfor_block(self.block_name, value=initial_block_value , maxwait=TIMEOUT) assert_that(check_block_exists(self.block_name), is_(True)) def test_GIVEN_waiting_for_exact_value_on_block_WHEN_block_reaches_value_THEN_waitfor_completes( From b30701da04fb4ec8597ee77336eb357cef0c4514 Mon Sep 17 00:00:00 2001 From: Freddie Akeroyd Date: Sun, 27 Apr 2025 20:28:11 +0100 Subject: [PATCH 2/2] ruff --- test_genie_python_using_simple.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test_genie_python_using_simple.py b/test_genie_python_using_simple.py index 2b0da45..6cd548b 100644 --- a/test_genie_python_using_simple.py +++ b/test_genie_python_using_simple.py @@ -238,7 +238,7 @@ def setUp(self): self.max_wait = (self.wait_before + self.wait_after) * 2 initial_block_value = 0 g.cset(self.block_name, initial_block_value) - g.waitfor_block(self.block_name, value=initial_block_value , maxwait=TIMEOUT) + g.waitfor_block(self.block_name, value=initial_block_value, maxwait=TIMEOUT) assert_that(check_block_exists(self.block_name), is_(True)) def test_GIVEN_waiting_for_exact_value_on_block_WHEN_block_reaches_value_THEN_waitfor_completes(